[receiver/prometheusreceiver] Configuring httpSD http client from TAs clienthttp #34035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItielOlenick
changed the title
…g-from-TAs-confighttp
ItielOlenick
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Keep alive |
dashpole
approved these changes
Jul 31, 2024
|
From failing CI/CD action: |
|
Failing connector test is unrelated to this change, I've filed #34487 to address it. |
|
@crobert-1 Ran make gotidy |
crobert-1
added
the
ready to merge
|
Added |
|
@ItielOlenick can you please rebase to fix the conflict? |
ItielOlenick
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
crobert-1,
atoulme and
jmacd
as code owners
github-actions
bot
added
cmd/githubgen
cmd/opampsupervisor
cmd/otelcontribcol
ItielOlenick
force-pushed
the
httpSD-client-config-from-TAs-confighttp
branch
from
674bb4f to
dd323f2
Compare
|
@dmitryax Done |
|
@dmitryax @crobert-1 Can we get this merged? |
andrzej-stencel
approved these changes
Aug 19, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
… clienthttp (open-telemetry#34035) **Description:** Translating relevant fields from TargetAllocator's confighttps to be used in the service discovery http client config This assures that the relevant config defiend for the TA is used by the service discovery jobs in addition to the scrape configs (as solved by open-telemetry#31449) **Link to tracking Issue:** Resolves open-telemetry#33370 **Testing:** Added unit tests. **Documentation:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Translating relevant fields from TargetAllocator's confighttps to be used in the service discovery http client config
This assures that the relevant config defiend for the TA is used by the service discovery jobs in addition to the scrape configs (as solved by #31449)
Link to tracking Issue: Resolves #33370
Testing:
Added unit tests.
Documentation: